Skip to content

feat: always-available AsyncRead#19

Merged
rousan merged 1 commit into
rwf2:developfrom
Fishrock123:futures_codec
Nov 20, 2020
Merged

feat: always-available AsyncRead#19
rousan merged 1 commit into
rwf2:developfrom
Fishrock123:futures_codec

Conversation

@Fishrock123
Copy link
Copy Markdown
Contributor

Since multer already uses the whole of futures, it feels like using futures_codec should be the default.

This switches the "reader" feature to be "tokio-io". (semver-major)


(note: this is awaiting #18)

@rousan rousan marked this pull request as ready for review November 5, 2020 03:40
@rousan
Copy link
Copy Markdown
Member

rousan commented Nov 5, 2020

I think, the doc for the with_reader function also needs to be updated as we removed the reader feature.

Since multer already uses the whole of futures, it feels like using `futures_codec` should be the default.

This switches the `"reader"` feature to be `"tokio-io"`. (semver-major)
@rousan rousan merged commit 809e37a into rwf2:develop Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants